]> granicus.if.org Git - postgresql/commit
Restrict pgbench's zipfian parameter to ensure good performance.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 1 Apr 2019 21:37:26 +0000 (17:37 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 1 Apr 2019 21:37:34 +0000 (17:37 -0400)
commit26a76cb64072df6fa5585c2c15df39970ccdce01
tree80a79706dff2d1a97c2e790619f887b38fd65383
parent4fd05bb55b40a3c9dde2b19942f275fc31b5225a
Restrict pgbench's zipfian parameter to ensure good performance.

Remove the code that supported zipfian distribution parameters less
than 1.0, as it had undocumented performance hazards, and it's not
clear that the case is useful enough to justify either fixing or
documenting those hazards.

Also, since the code path for parameter > 1.0 could perform badly
for values very close to 1.0, establish a minimum allowed value
of 1.001.  This solution seems superior to the previous vague
documentation warning about small values not performing well.

Fabien Coelho, per a gripe from Tomas Vondra

Discussion: https://postgr.es/m/b5e172e9-ad22-48a3-86a3-589afa20e8f7@2ndquadrant.com
doc/src/sgml/ref/pgbench.sgml
src/bin/pgbench/pgbench.c
src/bin/pgbench/t/001_pgbench_with_server.pl