]> granicus.if.org Git - python/commit
bpo-35441: Remove dead and buggy code related to PyList_SetItem(). (GH-11033)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Sat, 8 Dec 2018 14:39:37 +0000 (06:39 -0800)
committerGitHub <noreply@github.com>
Sat, 8 Dec 2018 14:39:37 +0000 (06:39 -0800)
commit25555e0fbed15f809a247c7e16ab9d0a0088f806
treeea790ba8966889dc230ebe1f22c0321ea331e605
parent12b9fb603eea9298c835bae5b8742db4fa52892e
bpo-35441: Remove dead and buggy code related to PyList_SetItem(). (GH-11033)

In _localemodule.c and selectmodule.c, remove dead code that would
cause double decrefs if run.

In addition, replace PyList_SetItem() with PyList_SET_ITEM() in cases
where a new list is populated and there is no possibility of an error.

In addition, check if the list changed size in the loop in array_array_fromlist().
(cherry picked from commit 99d56b53560b3867844472ae381fb3f858760621)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Modules/_localemodule.c
Modules/arraymodule.c
Modules/readline.c
Modules/selectmodule.c
PC/winreg.c
Python/ceval.c
Python/sysmodule.c