]> granicus.if.org Git - postgresql/commit
When a GiST page is split during index build, it might not have a buffer.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Fri, 2 Mar 2012 11:16:09 +0000 (13:16 +0200)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Fri, 2 Mar 2012 11:16:09 +0000 (13:16 +0200)
commit2502f45979fca76a6b19a07c98d7a41737a3dc7b
tree9a9b8864af37875045268276575a0d4456c948b8
parentbc8765e91c743d87f5658387b41e3a61cde54116
When a GiST page is split during index build, it might not have a buffer.

Previously it was thought that it's impossible as the code stands, because
insertions create buffers as tuples are cascaded downwards, and index
split also creaters buffers eagerly for all halves. But the example from
Jay Levitt demonstrates that it can happen, when the root page is split.
It's in fact OK if the buffer doesn't exist, so we just need to remove the
sanity check. In fact, we've been discussing the possibility of destroying
empty buffers to conserve memory, which would render the sanity check
completely useless anyway.

Fix by Alexander Korotkov
src/backend/access/gist/gistbuildbuffers.c