]> granicus.if.org Git - postgresql/commit
Fix RelationIdGetRelation calls that weren't bothering with error checks.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 8 Sep 2019 21:00:29 +0000 (17:00 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 8 Sep 2019 21:00:52 +0000 (17:00 -0400)
commit2403e54fff3b47735fc1a77c51e407c3596d3331
treea71bd00aa8ec695e8ccc917764bc992b8a9b15fb
parente6af7b367cf46fc385307efcef5a1fece0e5fef3
Fix RelationIdGetRelation calls that weren't bothering with error checks.

Some of these are quite old, but that doesn't make them not bugs.
We'd rather report a failure via elog than SIGSEGV.

While at it, uniformly spell the error check as !RelationIsValid(rel)
rather than a bare rel == NULL test.  The machine code is the same
but it seems better to be consistent.

Coverity complained about this today, not sure why, because the
mistake is in fact old.
src/backend/replication/logical/reorderbuffer.c