]> granicus.if.org Git - postgresql/commit
Fix issues with wide tuples being updated and REPLICA IDENTITY FULL.
authorAndres Freund <andres@anarazel.de>
Sat, 5 Aug 2017 21:32:01 +0000 (14:32 -0700)
committerAndres Freund <andres@anarazel.de>
Sat, 5 Aug 2017 21:56:40 +0000 (14:56 -0700)
commit23a2b818f50ff9e1beb73c31cd902a2140476c30
tree4f67b41edcbf017762752a28832987d620bda479
parent8d05db3d8e0c507d2e1fead4acceed73565e3ccc
Fix issues with wide tuples being updated and REPLICA IDENTITY FULL.

When replica identity full is being used with a wide tuple (above 2^16
bytes after compression) it lead to errors and/or crashes during
decoding because the length field used to store such tuples doesn't
fit into the variable used to store the width in the WAL record.

To fix, discontinue use of xl_heap_header_len.t_len when decoding the
old tuple version, instead compute length of the old tuple by
subtracting the new tuple's length from the record length.

In newer version of postgres this issue is moot because the length is
stored by the new WAL machinery, instead of a xl_heap_header_len
struct.  A separate commit will forward-patch the regression test.

Reported-By: "anderson"
Discussion: http://postgr.es/m/20170105144819.f6i5o64vfvy4bn5i@alap3.anarazel.de
contrib/test_decoding/expected/toast.out
contrib/test_decoding/sql/toast.sql
src/backend/access/heap/heapam.c
src/backend/replication/logical/decode.c