]> granicus.if.org Git - postgresql/commit
Fix corner-case coredump in _SPI_error_callback().
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 11 Dec 2017 21:33:20 +0000 (16:33 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 11 Dec 2017 21:33:49 +0000 (16:33 -0500)
commit239b01e313b5c3bc90d383b0a345e0549fe9ba96
tree59b9ce22f753c21ac9eff05f83f9a90c13f0a3d7
parentd78c3ca0ea1012d9c944bae981b13151e4f86dcb
Fix corner-case coredump in _SPI_error_callback().

I noticed that _SPI_execute_plan initially sets spierrcontext.arg = NULL,
and only fills it in some time later.  If an error were to happen in
between, _SPI_error_callback would try to dereference the null pointer.
This is unlikely --- there's not much between those points except
push-snapshot calls --- but it's clearly not impossible.  Tweak the
callback to do nothing if the pointer isn't set yet.

It's been like this for awhile, so back-patch to all supported branches.
src/backend/executor/spi.c