Check DCH_MAX_ITEM_SIZ limits with <=, not <.
authorNoah Misch <noah@leadboat.com>
Sat, 7 Feb 2015 04:39:52 +0000 (23:39 -0500)
committerNoah Misch <noah@leadboat.com>
Sat, 7 Feb 2015 04:39:52 +0000 (23:39 -0500)
commit237795a7b4ccf359423bdd99476782d4880eda83
tree541939ce2eb6f9a156598f77242f409db00c6dd6
parenta7a4adcf8d1e5a34a15ad86aee7d6aa0b8c15d43
Check DCH_MAX_ITEM_SIZ limits with <=, not <.

We reserve space for the full amount, not one less.  The affected checks
deal with localized month and day names.  Today's DCH_MAX_ITEM_SIZ value
would suffice for a 60-byte day name, while the longest known is the
49-byte mn_CN.utf-8 word for "Saturday."  Thus, the upshot of this
change is merely to avoid misdirecting future readers of the code; users
are not expected to see errors either way.
src/backend/utils/adt/formatting.c