]> granicus.if.org Git - libvpx/commit
Revert "Add visibility="protected" attribute for global variables referenced in asm...
authorJohann Koenig <johannkoenig@google.com>
Tue, 16 May 2017 22:52:15 +0000 (22:52 +0000)
committerJohann <johannkoenig@google.com>
Tue, 16 May 2017 22:54:33 +0000 (15:54 -0700)
commit2300e16675c2f526fc6a15246ffbe5aabbd5ea5f
tree37bd8a7346a84b98a04670065462d94cb9212dec
parentdac3b597219a2befd2f1dc1c9cd4ff347a90f572
Revert "Add visibility="protected" attribute for global variables referenced in asm files."

This reverts commit 0d88e15454b632d92404dd6a7181c58d9985e2a2.

Reason for revert: chromium builds are failing to locate vpx_rv during dlopen()

dlopen failed: cannot locate symbol "vpx_rv" referenced by "libstandalonelibwebviewchromium.so"

Original change's description:
> Add visibility="protected" attribute for global variables referenced in asm files.
>
> During aosp builds with binutils-2.27, we're seeing linker error
> messages of this form:
> libvpx.a(subpixel_mmx.o): relocation R_386_GOTOFF against preemptible
> symbol vp8_bilinear_filters_x86_8 cannot be used when making a shared
> object
>
> subpixel_mmx.o is assembled from "vp8/common/x86/subpixel_mmx.asm".
> Other messages refer to symbol references from deblock_sse2.o and
> subpixel_sse2.o, also assembled from asm files.
>
> This change marks such symbols as having "protected" visibility. This
> satisfies the linker as the symbols are not preemptible from outside
> the shared library now, which I think is the original intent anyway.
>
> Change-Id: I2817f7a5f43041533d65ebf41aefd63f8581a452
>

TBR=jzern@google.com,johannkoenig@google.com,rahulchaudhry@chromium.org,builds@webmproject.org

Change-Id: I0c2ea375aa7ef5fda15b9d9e23e654bb315c941b
vp8/common/x86/filter_x86.c
vpx_dsp/deblock.c
vpx_ports/mem.h