]> granicus.if.org Git - postgresql/commit
Correct off-by-one when reading from pipe
authorStephen Frost <sfrost@snowman.net>
Mon, 15 Jul 2013 14:42:27 +0000 (10:42 -0400)
committerStephen Frost <sfrost@snowman.net>
Mon, 15 Jul 2013 14:48:01 +0000 (10:48 -0400)
commit22b7f5c5aa1dc2909e110b171b03d6e0c85dcd43
tree260a45a57736e36903a19d01cb9447d73d9f694b
parent8126bfb5b5f0b413455edd23ff3bf08d83f1cddc
Correct off-by-one when reading from pipe

In pg_basebackup.c:reached_end_position(), we're reading from an
internal pipe with our own background process but we're possibly
reading more bytes than will actually fit into our buffer due to
an off-by-one error.  As we're reading from an internal pipe
there's no real risk here, but it's good form to not depend on
such convenient arrangements.

Bug spotted by the Coverity scanner.

Back-patch to 9.2 where this showed up.
src/bin/pg_basebackup/pg_basebackup.c