]> granicus.if.org Git - clang/commit
Revert r325375 "[MS] Make constexpr static data members implicitly inline"
authorHans Wennborg <hans@hanshq.net>
Tue, 20 Feb 2018 12:43:02 +0000 (12:43 +0000)
committerHans Wennborg <hans@hanshq.net>
Tue, 20 Feb 2018 12:43:02 +0000 (12:43 +0000)
commit21eb8b6347db238d89b9df37eb5f36e6b7542e32
tree1a89d616ada9939123b6ff1d8cced6063c30dccd
parente12ed2f1cb6b9910b33e2a3b4b66d91342191797
Revert r325375 "[MS] Make constexpr static data members implicitly inline"

This broke Clang bootstrap on Windows, PR36453.

> This handles them exactly the same way that we handle const integral
> static data members with inline definitions, which is what MSVC does.
>
> As a follow-up, now that we have a way to mark variables inline in the
> AST, we should consider marking them implicitly inline there instead of
> only treating them as inline in CodeGen. Unfortunately, this breaks a
> lot of dllimport test cases, so that is future work for now.
>
> Fixes PR36125.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@325576 91177308-0d34-0410-b5e6-96231b3b80d8
lib/AST/ASTContext.cpp
test/CodeGenCXX/static-data-member.cpp