]> granicus.if.org Git - postgresql/commit
Avoid possibly accessing off the end of memory in SJIS2004 conversion.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 6 Sep 2011 18:50:28 +0000 (14:50 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 6 Sep 2011 18:51:31 +0000 (14:51 -0400)
commit1f036c3f8a1aa80182037f2fb0706c0270b0492d
tree997af650391d5508d33e5bcbba3cb458296ce076
parent3cfb60272ce6dc95ea367446fb20db91ed05476e
Avoid possibly accessing off the end of memory in SJIS2004 conversion.

The code in shift_jis_20042euc_jis_2004() would fetch two bytes even when
only one remained in the string.  Since conversion functions aren't
supposed to assume null-terminated input, this poses a small risk of
fetching past the end of memory and incurring SIGSEGV.  No such crash has
been identified in the field, but we've certainly seen the equivalent
happen in other code paths, so patch this one all the way back.

Report and patch by Noah Misch.
src/backend/utils/mb/conversion_procs/euc_jis_2004_and_shift_jis_2004/euc_jis_2004_and_shift_jis_2004.c