]> granicus.if.org Git - llvm/commit
[FileCheck] Introduce substitution subclasses
authorThomas Preud'homme <thomasp@graphcore.ai>
Thu, 23 May 2019 00:10:29 +0000 (00:10 +0000)
committerThomas Preud'homme <thomasp@graphcore.ai>
Thu, 23 May 2019 00:10:29 +0000 (00:10 +0000)
commit1e8636f15a85e7ebb6908aa8a67a54eb8f7ac5c7
treeed2167ac28dffc8097394014527d19f42675e985
parent7b079c65a12626e3e2370bc870990f07c9e1ba2b
[FileCheck] Introduce substitution subclasses

Summary:
With now a clear distinction between string and numeric substitutions,
this patch introduces separate classes to represent them with a parent
class implementing the common interface. Diagnostics in
printSubstitutions() are also adapted to not require knowing which
substitution is being looked at since it does not hinder clarity and
makes the implementation simpler.

Reviewers: jhenderson, jdenny, probinson, arichardson

Subscribers: llvm-commits, probinson, arichardson, hiraditya

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D62241

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@361446 91177308-0d34-0410-b5e6-96231b3b80d8
include/llvm/Support/FileCheck.h
lib/Support/FileCheck.cpp
test/FileCheck/numeric-defines.txt
test/FileCheck/string-defines.txt
test/FileCheck/verbose.txt
unittests/Support/FileCheckTest.cpp