]> granicus.if.org Git - postgresql/commit
Fix a gradual memory leak in ExecReScanAgg(). Because the aggregation
authorNeil Conway <neilc@samurai.com>
Wed, 8 Aug 2007 18:07:02 +0000 (18:07 +0000)
committerNeil Conway <neilc@samurai.com>
Wed, 8 Aug 2007 18:07:02 +0000 (18:07 +0000)
commit1de589bfcb6c2bbf9772b1f095909698f578056c
treeecf8693b6a345f8f0fb8eeecf0a2f4ce07888a3f
parent6d1607dc3f83d1de9b4daeba2f0622e29cafc524
Fix a gradual memory leak in ExecReScanAgg(). Because the aggregation
hash table is allocated in a child context of the agg node's memory
context, MemoryContextReset() will reset but *not* delete the child
context. Since ExecReScanAgg() proceeds to build a new hash table
from scratch (in a new sub-context), this results in leaking the
header for the previous memory context. Therefore, use
MemoryContextResetAndDeleteChildren() instead.

Credit: My colleague Sailesh Krishnamurthy at Truviso for isolating
the cause of the leak.
src/backend/executor/nodeAgg.c