]> granicus.if.org Git - postgresql/commit
Fix to_char() to use ASCII-only case-folding rules where appropriate.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 5 Mar 2013 18:02:35 +0000 (13:02 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 5 Mar 2013 18:02:35 +0000 (13:02 -0500)
commit1db236c74a2bc21178e4275bba7329d5cf3aaf55
treed859dff4be914032e5c4d5f28b5b3238f91847d0
parentfa852303f0cda557e620af775c2e96b56eb365ba
Fix to_char() to use ASCII-only case-folding rules where appropriate.

formatting.c used locale-dependent case folding rules in some code paths
where the result isn't supposed to be locale-dependent, for example
to_char(timestamp, 'DAY').  Since the source data is always just ASCII
in these cases, that usually didn't matter ... but it does matter in
Turkish locales, which have unusual treatment of "i" and "I".  To confuse
matters even more, the misbehavior was only visible in UTF8 encoding,
because in single-byte encodings we used pg_toupper/pg_tolower which
don't have locale-specific behavior for ASCII characters.  Fix by providing
intentionally ASCII-only case-folding functions and using these where
appropriate.  Per bug #7913 from Adnan Dursun.  Back-patch to all active
branches, since it's been like this for a long time.
src/backend/utils/adt/formatting.c
src/include/utils/formatting.h