]> granicus.if.org Git - postgresql/commit
Fix RelationIdGetRelation calls that weren't bothering with error checks.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 8 Sep 2019 21:00:29 +0000 (17:00 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 8 Sep 2019 21:00:56 +0000 (17:00 -0400)
commit1d87b674828ad3d49b74d0190184d861f183fb30
tree0730ed8a97f22517bcec44807502ebc8a481f049
parenta5431b7d5f6bcccd1fc69c4e4ae6e4d5f39b83f8
Fix RelationIdGetRelation calls that weren't bothering with error checks.

Some of these are quite old, but that doesn't make them not bugs.
We'd rather report a failure via elog than SIGSEGV.

While at it, uniformly spell the error check as !RelationIsValid(rel)
rather than a bare rel == NULL test.  The machine code is the same
but it seems better to be consistent.

Coverity complained about this today, not sure why, because the
mistake is in fact old.
src/backend/access/heap/heapam.c
src/backend/replication/logical/reorderbuffer.c