granicus.if.org Git - postgresql/commit

author	Robert Haas <rhaas@postgresql.org>
	Wed, 12 Apr 2017 15:13:44 +0000 (11:13 -0400)
committer	Robert Haas <rhaas@postgresql.org>
	Wed, 12 Apr 2017 15:35:11 +0000 (11:35 -0400)
commit	1d5fede4a900d135745c1fa5a70dcfe0b3359e3d
tree	620b3a368e148c593da95dd2bbed8f63656c723a	tree \| snapshot
parent	b935eb7da37254a18c48acc7b07517c8dfbb2339	commit \| diff

Code review for c94e6942cefe7d20c5feed856e27f672734b1e2b.

validateCheckConstraint() shouldn't try to access the storage for
a partitioned table, because it no longer has any. Creating a
_RETURN table on a partitioned table shouldn't be allowed, both
because there's no value in it and because trying to do so would
involve a validation scan against its nonexistent storage.

Amit Langote, reviewed by Tom Lane. Regression test outputs
updated to pass by me.

Discussion: http://postgr.es/m/e5c3cbd3-1551-d6f8-c9e2-51777d632fd2@lab.ntt.co.jp

src/backend/commands/tablecmds.c		diff \| blob \| history
src/backend/rewrite/rewriteDefine.c		diff \| blob \| history
src/test/regress/expected/alter_table.out		diff \| blob \| history
src/test/regress/expected/rules.out		diff \| blob \| history
src/test/regress/sql/alter_table.sql		diff \| blob \| history
src/test/regress/sql/rules.sql		diff \| blob \| history