]> granicus.if.org Git - clang/commit
Revert r149083 which is not the direction we're going in the Clang
authorChandler Carruth <chandlerc@gmail.com>
Tue, 31 Jan 2012 02:21:20 +0000 (02:21 +0000)
committerChandler Carruth <chandlerc@gmail.com>
Tue, 31 Jan 2012 02:21:20 +0000 (02:21 +0000)
commit1d16f0f805c2a3e2198a87154990347b2759f6bd
tree7afce7b50a405477874544763ef4a98a8338f373
parentb9b0f6fb6e113b5e6be3ed9754c4bf01186a17bf
Revert r149083 which is not the direction we're going in the Clang
driver based on discussions with Doug Gregor. There are several issues:
1) The patch was not reviewed prior to commit and there were review comments.
2) The design of the functionality (triple-prefixed tool invocation)
   isn't the design we want for Clang going forward: it focuses on the
   "user triple" rather than on the "toolchain triple", and forces that
   bit of state into the API of every single toolchain instead of
   handling it automatically in the common base classes.
3) The tests provided are not stable. They fail on a few Linux variants
   (Gentoo among them) and on mingw32 and some other environments.

I *am* interested in the Clang driver being able to invoke
triple-prefixed tools, but we need to design that feature the right way.
This patch just extends the previous hack without fixing the underlying
problems with it. I'm working on a new design for this that I will mail
for review by tomorrow.

I am aware that this removes functionality that NetBSD relies on, but
this is ToT, not a release. This functionality hasn't been properly
designed, implemented, and tested yet. We can't "regress" until we get
something that really works, both with the immediate use cases and with
long term maintenance of the Clang driver.

For reference, the original commit log:
Keep track of the original target the user specified before
normalization. This used to be captured in DefaultTargetTriple and is
used for the (optional) $triple-$tool lookup for cross-compilation.
Do this properly by making it an attribute of the toolchain and use it
in combination with the computed triple as index for the toolchain
lookup.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@149337 91177308-0d34-0410-b5e6-96231b3b80d8
include/clang/Driver/ToolChain.h
lib/Driver/Driver.cpp
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
lib/Driver/WindowsToolChain.cpp
test/Driver/prefixed-tools.c [deleted file]
test/Driver/prefixed-tools.c-helper/x86_64--linux-as [deleted file]
test/Driver/prefixed-tools.c-helper/x86_64--linux-ld [deleted file]