]> granicus.if.org Git - postgresql/commit
Don't allow foreign tables with OIDs.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 24 Jun 2014 09:31:36 +0000 (12:31 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 24 Jun 2014 10:30:54 +0000 (13:30 +0300)
commit1c9f9e888fc2d86446f445d768ff076b1643e167
tree0163751ec94035767b0b7e5d3d97a954f84a0f4e
parent07353de4fbcd7ee93a445dc6bf2bb32f05fffef1
Don't allow foreign tables with OIDs.

The syntax doesn't let you specify "WITH OIDS" for foreign tables, but it
was still possible with default_with_oids=true. But the rest of the system,
including pg_dump, isn't prepared to handle foreign tables with OIDs
properly.

Backpatch down to 9.1, where foreign tables were introduced. It's possible
that there are databases out there that already have foreign tables with
OIDs. There isn't much we can do about that, but at least we can prevent
them from being created in the future.

Patch by Etsuro Fujita, reviewed by Hadi Moshayedi.
src/backend/commands/tablecmds.c