]> granicus.if.org Git - postgresql/commit
Fix planning of parameterized appendrel paths with expensive join quals.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 8 Jul 2013 02:37:32 +0000 (22:37 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 8 Jul 2013 02:37:32 +0000 (22:37 -0400)
commit1bd25c03487dd2f96035f88c77fc0d89bb438fac
treeba2f424a103b3371d82a90a3c7088dd5c9b99f55
parent62ba0c12e599a377b3c1f1c94e0018a7c6f348ec
Fix planning of parameterized appendrel paths with expensive join quals.

The code in set_append_rel_pathlist() for building parameterized paths
for append relations (inheritance and UNION ALL combinations) supposed
that the cheapest regular path for a child relation would still be cheapest
when reparameterized.  Which might not be the case, particularly if the
added join conditions are expensive to compute, as in a recent example from
Jeff Janes.  Fix it to compare child path costs *after* reparameterizing.
We can short-circuit that if the cheapest pre-existing path is already
parameterized correctly, which seems likely to be true often enough to be
worth checking for.

Back-patch to 9.2 where parameterized paths were introduced.
src/backend/optimizer/path/allpaths.c
src/test/regress/expected/union.out
src/test/regress/sql/union.sql