]> granicus.if.org Git - cgit/commit
ui-shared: don't print path crumbs without a repo
authorJohn Keeping <john@keeping.me.uk>
Sun, 19 Feb 2017 12:27:48 +0000 (12:27 +0000)
committerJason A. Donenfeld <Jason@zx2c4.com>
Thu, 10 Aug 2017 14:05:07 +0000 (16:05 +0200)
commit1b4ef6783a71962f8b5da3a23f2830f0f0f55ea0
tree37faf12c4a5d56ec24a886bb82956d206a6f3a57
parent6d3c8bc37f6124c2193d66587079975d381aa435
ui-shared: don't print path crumbs without a repo

cgit_print_path_crumbs() can call repolink() which assumes that ctx.repo
is non-null.  Currently we don't have any commands that set want_vpath
without also setting want_repo so it shouldn't be possible to fail this
test, but the check in cgit.c is in the wrong order so it is possible to
specify a query string like "?p=log&path=foo/bar" to end up here without
a valid repository.

This was found by American fuzzy lop [0].

[0] http://lcamtuf.coredump.cx/afl/

Signed-off-by: John Keeping <john@keeping.me.uk>
ui-shared.c