]> granicus.if.org Git - postgresql/commit
initdb -S should now have an explicit check that $PGDATA is valid.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 29 May 2015 21:02:58 +0000 (17:02 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 29 May 2015 21:02:58 +0000 (17:02 -0400)
commit1943c000b7a22d3ca334196cfe3f7b8159b210c2
tree94f1c0ee02196cc1b03e8f8e721937491d8e9816
parent57e1138bcc621ffeb8b1f1379ac4016a5c34d43e
initdb -S should now have an explicit check that $PGDATA is valid.

The fsync code from the backend essentially assumes that somebody's already
validated PGDATA, at least to the extent of it being a readable directory.
That's safe enough for initdb's normal code path too, but "initdb -S"
doesn't have any other processing at all that touches the target directory.
To have reasonable error-case behavior, add a pg_check_dir call.
Per gripe from Peter E.
src/bin/initdb/initdb.c