]> granicus.if.org Git - postgresql/commit
Don't assume a subquery's output is unique if there's a SRF in its tlist.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 8 Jul 2014 18:03:23 +0000 (14:03 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 8 Jul 2014 18:03:23 +0000 (14:03 -0400)
commit189bd09cbde8e80a188be57c19860384ab627ada
treece1519bcd24074b28330cccee783e119778f4442
parent759c9fb631fbb3a1d28b24979e0d512e3a571d5c
Don't assume a subquery's output is unique if there's a SRF in its tlist.

While the x output of "select x from t group by x" can be presumed unique,
this does not hold for "select x, generate_series(1,10) from t group by x",
because we may expand the set-returning function after the grouping step.
(Perhaps that should be re-thought; but considering all the other oddities
involved with SRFs in targetlists, it seems unlikely we'll change it.)
Put a check in query_is_distinct_for() so it's not fooled by such cases.

Back-patch to all supported branches.

David Rowley
src/backend/optimizer/util/pathnode.c
src/test/regress/expected/subselect.out
src/test/regress/sql/subselect.sql