]> granicus.if.org Git - python/commit
bpo-37140: Fix StructUnionType_paramfunc() (GH-15612)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Fri, 30 Aug 2019 12:50:44 +0000 (05:50 -0700)
committerGitHub <noreply@github.com>
Fri, 30 Aug 2019 12:50:44 +0000 (05:50 -0700)
commit17f61ed25a856ed673ad6f2e9782c3d5e556f151
treea5d2ac5780b2fe9ba5f9e196027158177dd7ebf3
parent1553e3b5fc97512940826f4fa2c8bc45d88c84cb
bpo-37140: Fix StructUnionType_paramfunc() (GH-15612)

Fix a ctypes regression of Python 3.8. When a ctypes.Structure is
passed by copy to a function, ctypes internals created a temporary
object which had the side effect of calling the structure finalizer
(__del__) twice. The Python semantics requires a finalizer to be
called exactly once. Fix ctypes internals to no longer call the
finalizer twice.

Create a new internal StructParam_Type which is only used by
_ctypes_callproc() to call PyMem_Free(ptr) on Py_DECREF(argument).
StructUnionType_paramfunc() creates such object.
(cherry picked from commit 96b4087ce784ee7434dffdf69c475f5b40543982)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Lib/ctypes/test/test_structures.py
Misc/NEWS.d/next/Library/2019-08-30-11-21-10.bpo-37140.cFAX-a.rst [new file with mode: 0644]
Modules/_ctypes/_ctypes.c