]> granicus.if.org Git - llvm/commit
Bitcode: Don't optimize constants when preserving use-list order
authorDuncan P. N. Exon Smith <dexonsmith@apple.com>
Fri, 25 Jul 2014 16:13:16 +0000 (16:13 +0000)
committerDuncan P. N. Exon Smith <dexonsmith@apple.com>
Fri, 25 Jul 2014 16:13:16 +0000 (16:13 +0000)
commit17cb4cb5a37dddf858629ea0181179acaf8c695f
tree5b200ab19823f2209fa86c6b445d3ee294034d34
parente27d5a0047416ba498b3675f16bf38b85287fb26
Bitcode: Don't optimize constants when preserving use-list order

`ValueEnumerator::OptimizeConstants()` creates forward references within
the constant pools, which makes predicting constants' use-list order
difficult.  For now, just disable the optimization.

This can be re-enabled in the future in one of two ways:

  - Enable a limited version of this optimization that doesn't create
    forward references.  One idea is to categorize constants by their
    "height" and make that the top-level sort.

  - Enable it entirely.  This requires predicting how may times each
    constant will be recreated as its operands' and operands' operands'
    (etc.) forward references get resolved.

This is part of PR5680.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@213953 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Bitcode/Writer/ValueEnumerator.cpp