]> granicus.if.org Git - postgresql/commit
Clean up the #include mess a little.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 4 Sep 2011 05:13:16 +0000 (01:13 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 4 Sep 2011 05:13:16 +0000 (01:13 -0400)
commit1609797c25f6b440371045039733d69fe8cb9410
tree7bd7b661545d483b19e11e33fccde8eee9b6c61b
parentf116b1f5b8d36e54404b36f1aba1295cbcfc4fdc
Clean up the #include mess a little.

walsender.h should depend on xlog.h, not vice versa.  (Actually, the
inclusion was circular until a couple hours ago, which was even sillier;
but Bruce broke it in the expedient rather than logically correct
direction.)  Because of that poor decision, plus blind application of
pgrminclude, we had a situation where half the system was depending on
xlog.h to include such unrelated stuff as array.h and guc.h.  Clean up
the header inclusion, and manually revert a lot of what pgrminclude had
done so things build again.

This episode reinforces my feeling that pgrminclude should not be run
without adult supervision.  Inclusion changes in header files in particular
need to be reviewed with great care.  More generally, it'd be good if we
had a clearer notion of module layering to dictate which headers can sanely
include which others ... but that's a big task for another day.
74 files changed:
contrib/auto_explain/auto_explain.c
contrib/cube/cube.c
contrib/pg_stat_statements/pg_stat_statements.c
contrib/tsearch2/tsearch2.c
src/backend/access/common/reloptions.c
src/backend/access/gin/ginarrayproc.c
src/backend/access/transam/slru.c
src/backend/access/transam/twophase_rmgr.c
src/backend/access/transam/varsup.c
src/backend/access/transam/xact.c
src/backend/access/transam/xlogutils.c
src/backend/bootstrap/bootstrap.c
src/backend/catalog/dependency.c
src/backend/catalog/index.c
src/backend/catalog/namespace.c
src/backend/catalog/pg_constraint.c
src/backend/commands/analyze.c
src/backend/commands/discard.c
src/backend/commands/functioncmds.c
src/backend/commands/indexcmds.c
src/backend/commands/sequence.c
src/backend/commands/tablespace.c
src/backend/commands/vacuum.c
src/backend/executor/nodeIndexscan.c
src/backend/executor/nodeSubplan.c
src/backend/executor/nodeTidscan.c
src/backend/optimizer/util/predtest.c
src/backend/parser/parse_clause.c
src/backend/postmaster/bgwriter.c
src/backend/postmaster/walwriter.c
src/backend/replication/syncrep.c
src/backend/replication/walreceiver.c
src/backend/replication/walreceiverfuncs.c
src/backend/replication/walsender.c
src/backend/storage/ipc/procarray.c
src/backend/storage/ipc/procsignal.c
src/backend/storage/lmgr/lwlock.c
src/backend/storage/smgr/smgr.c
src/backend/utils/adt/arrayfuncs.c
src/backend/utils/adt/enum.c
src/backend/utils/adt/int.c
src/backend/utils/adt/regexp.c
src/backend/utils/adt/ri_triggers.c
src/backend/utils/adt/ruleutils.c
src/backend/utils/cache/relcache.c
src/backend/utils/cache/relmapper.c
src/backend/utils/cache/spccache.c
src/backend/utils/fmgr/funcapi.c
src/backend/utils/hash/dynahash.c
src/backend/utils/resowner/resowner.c
src/backend/utils/time/combocid.c
src/backend/utils/time/snapmgr.c
src/include/access/gin.h
src/include/access/heapam.h
src/include/access/xact.h
src/include/access/xlog.h
src/include/access/xlog_internal.h
src/include/catalog/storage.h
src/include/commands/copy.h
src/include/commands/dbcommands.h
src/include/commands/portalcmds.h
src/include/commands/sequence.h
src/include/commands/tablespace.h
src/include/commands/trigger.h
src/include/executor/execdesc.h
src/include/executor/functions.h
src/include/executor/spi.h
src/include/replication/syncrep.h
src/include/replication/walsender.h
src/include/storage/standby.h
src/include/tcop/pquery.h
src/include/tcop/tcopprot.h
src/pl/plpgsql/src/pl_comp.c
src/pl/plpgsql/src/pl_handler.c