]> granicus.if.org Git - postgresql/commit
Fix SortTocFromFile() to cope with lines that are too long for its buffer.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 7 Apr 2011 15:40:23 +0000 (11:40 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 7 Apr 2011 15:40:23 +0000 (11:40 -0400)
commit1471a147f09f737511945ac59ca3162469d1a0c0
tree84156731e3ed9981ede37f473b7a00ef734f3d21
parent82a4f370735130418738f8cf0fb9155b1cff5e2b
Fix SortTocFromFile() to cope with lines that are too long for its buffer.

The original coding supposed that a dump TOC file could never contain lines
longer than 1K.  The folly of that was exposed by a recent report from
Per-Olov Esgard.  We only really need to see the first dozen or two bytes
of each line, since we're just trying to read off the numeric ID at the
start of the line; so there's no need for a particularly huge buffer.
What there is a need for is logic to not process continuation bufferloads.

Back-patch to all supported branches, since it's always been like this.
src/bin/pg_dump/pg_backup_archiver.c