]> granicus.if.org Git - clang/commit
This patch includes a conceptually simple, but very intrusive/pervasive change.
authorSteve Naroff <snaroff@apple.com>
Fri, 10 Jul 2009 23:34:53 +0000 (23:34 +0000)
committerSteve Naroff <snaroff@apple.com>
Fri, 10 Jul 2009 23:34:53 +0000 (23:34 +0000)
commit14108da7f7fc059772711e4ffee1322a27b152a7
tree5461a189505985c1c245c3f63a48030f0cd5e929
parent7ecbfbcddd278eede10bd38fa03a95a2110b191a
This patch includes a conceptually simple, but very intrusive/pervasive change.

The idea is to segregate Objective-C "object" pointers from general C pointers (utilizing the recently added ObjCObjectPointerType). The fun starts in Sema::GetTypeForDeclarator(), where "SomeInterface *" is now represented by a single AST node (rather than a PointerType whose Pointee is an ObjCInterfaceType). Since a significant amount of code assumed ObjC object pointers where based on C pointers/structs, this patch is very tedious. It should also explain why it is hard to accomplish this in smaller, self-contained patches.

This patch does most of the "heavy lifting" related to moving from PointerType->ObjCObjectPointerType. It doesn't include all potential "cleanups". The good news is additional cleanups can be done later (some are noted in the code). This patch is so large that I didn't want to include any changes that are purely aesthetic.

By making the ObjC types truly built-in, they are much easier to work with (and require fewer "hacks"). For example, there is no need for ASTContext::isObjCIdStructType() or ASTContext::isObjCClassStructType()! We believe this change (and the follow-up cleanups) will pay dividends over time.

Given the amount of code change, I do expect some fallout from this change (though it does pass all of the clang tests). If you notice any problems, please let us know asap! Thanks.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@75314 91177308-0d34-0410-b5e6-96231b3b80d8
43 files changed:
include/clang/AST/ASTContext.h
include/clang/AST/Type.h
include/clang/Analysis/PathSensitive/SVals.h
lib/AST/ASTContext.cpp
lib/AST/DeclObjC.cpp
lib/AST/Expr.cpp
lib/AST/ExprConstant.cpp
lib/AST/Type.cpp
lib/Analysis/BasicObjCFoundationChecks.cpp
lib/Analysis/CFRefCount.cpp
lib/Analysis/CheckNSError.cpp
lib/Analysis/CheckObjCInstMethSignature.cpp
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGExprScalar.cpp
lib/CodeGen/CGObjC.cpp
lib/CodeGen/CGObjCGNU.cpp
lib/CodeGen/CGObjCMac.cpp
lib/CodeGen/CodeGenTypes.cpp
lib/CodeGen/Mangle.cpp
lib/Frontend/PCHReader.cpp
lib/Frontend/PCHWriter.cpp
lib/Frontend/RewriteObjC.cpp
lib/Sema/Sema.cpp
lib/Sema/Sema.h
lib/Sema/SemaDecl.cpp
lib/Sema/SemaDeclAttr.cpp
lib/Sema/SemaDeclObjC.cpp
lib/Sema/SemaExpr.cpp
lib/Sema/SemaExprCXX.cpp
lib/Sema/SemaExprObjC.cpp
lib/Sema/SemaOverload.cpp
lib/Sema/SemaType.cpp
test/CodeGenObjC/encode-test.m
test/CodeGenObjC/overloadable.m
test/PCH/objc_exprs.m
test/SemaObjC/comptypes-5.m
test/SemaObjC/conditional-expr-3.m
test/SemaObjC/id.m
test/SemaObjC/message.m
test/SemaObjC/objc2-merge-gc-attribue-decl.m
test/SemaObjC/property-missing.m
test/SemaObjCXX/overload.mm