]> granicus.if.org Git - zfs/commit
OpenZFS 6585 - sha512, skein, and edonr have an unenforced dependency on extensible...
authorilovezfs <ilovezfs@icloud.com>
Thu, 28 Jan 2016 12:51:19 +0000 (04:51 -0800)
committerTony Hutter <hutter2@llnl.gov>
Mon, 3 Oct 2016 21:51:21 +0000 (14:51 -0700)
commit125a406e24fbfaec29557e88746210b9f18f646c
tree4007c3d17298909d0470c5c578def45d42f4cd53
parent4a2e9a17d5b81ae97b2a1b72437def9ed4996aca
OpenZFS 6585 - sha512, skein, and edonr have an unenforced dependency on extensible dataset

Authored by: ilovezfs <ilovezfs@icloud.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Approved by: Robert Mustacchi <rm@joyent.com>
Ported by: Tony Hutter <hutter2@llnl.gov>

In any pool without the extensible dataset feature flag already enabled,
creating a dataset with dedup set to use one of the new checksums would
result in the following panic as soon as any data was added:

panic[cpu0]/thread=ffffff0006761c40: feature_get_refcount(spa, feature,
&refcount) != 48 (0x30 != 0x30), file: ../../common/fs/zfs/zfeature.c
line 390

Inpsection showed that feature->fi_feature was 7, which is the value of
SPA_FEATURE_EXTENSIBLE_DATASET in the spa_feature enum.  This commit
adds extensible dataset as a dependency for the sha512, edonr, and skein
feature flags, which prevents the panic.

OpenZFS-issue: https://www.illumos.org/issues/6585
OpenZFS-commit: https://github.com/illumos/illumos-gate/commit/892586e8a147c02d7f4053cc405229a13e796928
Porting Notes:
This code was originally from Illumos, but I actually ported it from:
openzfsonosx/zfs@b62a652
man/man5/zpool-features.5
module/zfs/zfeature_common.c