]> granicus.if.org Git - postgresql/commit
Remove overzeleous assertions in pg_atomic_flag code.
authorAndres Freund <andres@anarazel.de>
Sun, 8 Apr 2018 01:27:14 +0000 (18:27 -0700)
committerAndres Freund <andres@anarazel.de>
Sun, 8 Apr 2018 01:30:15 +0000 (18:30 -0700)
commit11b1a39e1642611aa31f9151aa198711d966a1be
tree94978f7e4a4a03dbb5f2f336dc48521747504c9c
parent5b7fc7b0375e790542e879cd026ed90f2d0100c7
Remove overzeleous assertions in pg_atomic_flag code.

The atomics code asserts proper alignment in various places. That's
mainly because the alignment of 64bit integers is not sufficient for
atomic operations on all platforms. Some ABIs only have four byte
alignment, but don't have atomic behavior when crossing page
boundaries.

The flags code isn't affected by that however, as the type alignment
always is sufficient for atomic operations. Nevertheless the code
asserted alignment requirements. Before 8c3debbb it was only broken on
hppa, after it probably affect further platforms.

Thus remove the assertions for pg_atomic_flag operators.

Per buildfarm animal pademelon.

Discussion: https://postgr.es/m/7223.1523124425@sss.pgh.pa.us
Backpatch: 9.5-
src/include/port/atomics.h