]> granicus.if.org Git - postgresql/commit
Fix RelationIdGetRelation calls that weren't bothering with error checks.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 8 Sep 2019 21:00:29 +0000 (17:00 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 8 Sep 2019 21:00:50 +0000 (17:00 -0400)
commit1192e3fb54ce57f57399490d70af617ebc12605c
treef94d38d75e693e0801b17ae3857db09511611aa8
parent02f90879e75b3d4ccdba1ec7c3cad6af08dff77d
Fix RelationIdGetRelation calls that weren't bothering with error checks.

Some of these are quite old, but that doesn't make them not bugs.
We'd rather report a failure via elog than SIGSEGV.

While at it, uniformly spell the error check as !RelationIsValid(rel)
rather than a bare rel == NULL test.  The machine code is the same
but it seems better to be consistent.

Coverity complained about this today, not sure why, because the
mistake is in fact old.
src/backend/replication/logical/reorderbuffer.c