]> granicus.if.org Git - clang/commit
[CodeGen] Clarify comment about COFF common symbol alignment
authorShoaib Meenai <smeenai@fb.com>
Wed, 9 Jan 2019 20:05:16 +0000 (20:05 +0000)
committerShoaib Meenai <smeenai@fb.com>
Wed, 9 Jan 2019 20:05:16 +0000 (20:05 +0000)
commit10f093a07ea53c1b248948cca3cdbd8eae11d46a
tree6e34017191f3b9c0172b1b6d9569d3712490ce8a
parentac5aeb33f2780dfaea375c4da8d27f6d3eab520d
[CodeGen] Clarify comment about COFF common symbol alignment

After a discussion on the commit thread, it seems the 32 byte alignment
limitation is an MSVC toolchain artifact, not an inherent COFF
restriction. Clarify the comment accordingly, since saying COFF in the
comment but using isKnownWindowsMSVCEnvironment in the conditional is
confusing. Also add a newline before the comment, which is consistent
with the local style.

Differential Revision: https://reviews.llvm.org/D56466

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@350754 91177308-0d34-0410-b5e6-96231b3b80d8
lib/CodeGen/CodeGenModule.cpp