]> granicus.if.org Git - python/commit
projects / python / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 39b73dd) | patch
bpo-30264: ExpatParser closes the source on error (#1451) (#1474)
authorVictor Stinner <victor.stinner@gmail.com>
Fri, 5 May 2017 08:04:57 +0000 (10:04 +0200)
committerGitHub <noreply@github.com>
Fri, 5 May 2017 08:04:57 +0000 (10:04 +0200)
commit0fe870f3f95ba883b2b06bc0d814bdab8d53df98
treefd94539649980663fdcf0e89ac84dfd7d0ebaadatree | snapshot
parent39b73dd5131ce205dcee3b9e24ba0fc28934d79ccommit | diff
bpo-30264: ExpatParser closes the source on error (#1451) (#1474)

ExpatParser.parse() of xml.sax.xmlreader now always closes the
source: close the file object or the urllib object if source is a
string (not an open file-like object). The change fixes a
ResourceWarning on parsing error.

Add test_parse_close_source() unit test.
(cherry picked from commit ef9c0e732fc50aefbdd7c5a80e04e14b31684e66)
Lib/test/test_sax.py diff | blob | history
Lib/xml/sax/expatreader.py diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.