]> granicus.if.org Git - postgresql/commit
Fix busted Assert for CREATE MATVIEW ... WITH NO DATA.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 11 Aug 2016 15:22:25 +0000 (11:22 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 11 Aug 2016 15:22:25 +0000 (11:22 -0400)
commit0f249fe5f5cb3c83fd8e05743740b35ff5d34196
treea6ab98f665eaca42b68371cd700cb79de31548f1
parentfd5a2db774c1952567f75603dffb6d9fb0b0013d
Fix busted Assert for CREATE MATVIEW ... WITH NO DATA.

Commit 874fe3aea changed the command tag returned for CREATE MATVIEW/CREATE
TABLE AS ... WITH NO DATA, but missed that there was code in spi.c that
expected the command tag to always be "SELECT".  Fortunately, the
consequence was only an Assert failure, so this oversight should have no
impact in production builds.

Since this code path was evidently un-exercised, add a regression test.

Per report from Shivam Saxena. Back-patch to 9.3, like the previous commit.

Michael Paquier

Report: <97218716-480B-4527-B5CD-D08D798A0C7B@dresources.com>
src/backend/executor/spi.c
src/test/regress/expected/matview.out
src/test/regress/sql/matview.sql