]> granicus.if.org Git - postgresql/commit
Fix tab completion of "SET variable TO|=" to not offer bogus completions.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 2 Jul 2019 17:35:14 +0000 (13:35 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 2 Jul 2019 17:35:14 +0000 (13:35 -0400)
commit0ec3e13c69779117c8cfa39adcc6863631dedd44
tree18de4d93520332ed1fb01f5d4d9bbe48c71cf4a1
parent4d6603f28dfc4a1cab0d7d317855d935e314297a
Fix tab completion of "SET variable TO|=" to not offer bogus completions.

Don't think that the context "UPDATE tab SET var =" is a GUC-setting
command.

If we have "SET var =" but the "var" is not a known GUC variable,
don't offer any completions.  The most likely explanation is that
we've misparsed the context and it's not really a GUC-setting command.

Per gripe from Ken Tanzer.  Back-patch to 9.6.  The issue exists
further back, but before 9.6 the code looks very different and it
doesn't actually know whether the "var" name matches anything,
so I desisted from trying to fix it.

Discussion: https://postgr.es/m/CAD3a31XpXzrZA9TT3BqLSHghdTK+=cXjNCE+oL2Zn4+oWoc=qA@mail.gmail.com
src/bin/psql/tab-complete.c