]> granicus.if.org Git - llvm/commit
[MC] Don't recreate a label if it's already used
authorBill Wendling <isanbard@gmail.com>
Fri, 9 Aug 2019 20:16:31 +0000 (20:16 +0000)
committerBill Wendling <isanbard@gmail.com>
Fri, 9 Aug 2019 20:16:31 +0000 (20:16 +0000)
commit0cd6fdb03259dca095776dd98095e26b479a3876
treeca48210c892910d4f1bf9184bd8b296ae0da4498
parent92b342470ea5f5e73dba839be3f92a7d87087955
[MC] Don't recreate a label if it's already used

Summary:
This patch keeps track of MCSymbols created for blocks that were
referenced in inline asm. It prevents creating a new symbol which
doesn't refer to the block.

Inline asm may have a reference to a label. The asm parser however
doesn't recognize it as a label and tries to create a new symbol. The
result being that instead of the original symbol (e.g. ".Ltmp0") the
parser replaces it in the inline asm with the new one (e.g. ".Ltmp00")
without updating it in the symbol table. So the machine basic block
retains the "old" symbol (".Ltmp0"), but the inline asm uses the new one
(".Ltmp00").

Reviewers: nickdesaulniers, craig.topper

Subscribers: nathanchance, javed.absar, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D65304

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@368477 91177308-0d34-0410-b5e6-96231b3b80d8
include/llvm/MC/MCContext.h
lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp
lib/MC/MCContext.cpp
lib/MC/MCParser/AsmParser.cpp
test/CodeGen/AArch64/callbr-asm-label.ll [new file with mode: 0644]
test/CodeGen/X86/callbr-asm-label-addr.ll [new file with mode: 0644]
test/CodeGen/X86/callbr-asm.ll