]> granicus.if.org Git - python/commit
bpo-34872: Fix self-cancellation in C implementation of asyncio.Task (GH-9679)
authorElvis Pranskevichus <elvis@magic.io>
Wed, 3 Oct 2018 14:30:31 +0000 (10:30 -0400)
committerYury Selivanov <yury@magic.io>
Wed, 3 Oct 2018 14:30:31 +0000 (10:30 -0400)
commit0c797a6aca1c293e530e18c5e9fa02c670a9a4ed
tree0a7627593801b009925f9909715b8cacabf6c91e
parent96c593279400693226d5a560c420ae0fcf1731b9
bpo-34872: Fix self-cancellation in C implementation of asyncio.Task (GH-9679)

The C implementation of asyncio.Task currently fails to perform the
cancellation cleanup correctly in the following scenario.

    async def task1():
        async def task2():
            await task3     # task3 is never cancelled

        asyncio.current_task().cancel()
        await asyncio.create_task(task2())

The actuall error is a hardcoded call to `future_cancel()` instead of
calling the `cancel()` method of a future-like object.

Thanks to Vladimir Matveev for noticing the code discrepancy and to
Yury Selivanov for coming up with a pathological scenario.
Lib/test/test_asyncio/test_tasks.py
Misc/NEWS.d/next/Library/2018-10-02-19-36-34.bpo-34872.yWZRhI.rst [new file with mode: 0644]
Modules/_asynciomodule.c