[Analyzer] Replace `CXXSelfAssignmentBRVisitor` with `NoteTags`

[Analyzer] Replace `CXXSelfAssignmentBRVisitor` with `NoteTags`

The `cplusplus.SelfAssignment` checker has a visitor that is added
to every `BugReport` to mark the to branch of the self assignment
operator with e.g. `rhs == *this` and `rhs != *this`. With the new
`NoteTag` feature this visitor is not needed anymore. Instead the
checker itself marks the two branches using the `NoteTag`s.

Differential Revision: https://reviews.llvm.org/D62479

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@361818 91177308-0d34-0410-b5e6-96231b3b80d8