]> granicus.if.org Git - postgresql/commit
Avoid possible deadlock while locking multiple heap pages.
authorAmit Kapila <akapila@postgresql.org>
Sat, 2 Feb 2019 10:17:00 +0000 (15:47 +0530)
committerAmit Kapila <akapila@postgresql.org>
Sat, 2 Feb 2019 10:17:00 +0000 (15:47 +0530)
commit0b8bdb3c3ec092f18813d5b6fc738d7ec450289b
tree5a02375454059ffe82c48659dfe9b71e90b14ae6
parent3e938a83b2ee3b47d47cdbdf58df09946877d4fd
Avoid possible deadlock while locking multiple heap pages.

To avoid deadlock, backend acquires a lock on heap pages in block
number order.  In certain cases, lock on heap pages is dropped and
reacquired.  In this case, the locks are dropped for reading in
corresponding VM page/s. The issue is we re-acquire locks in bufferId
order whereas the intention was to acquire in blockid order.

This commit ensures that we will always acquire locks on heap pages in
blockid order.

Reported-by: Nishant Fnu
Author: Nishant Fnu
Reviewed-by: Amit Kapila and Robert Haas
Backpatch-through: 9.4
Discussion: https://postgr.es/m/5883C831-2ED1-47C8-BFAC-2D5BAE5A8CAE@amazon.com
src/backend/access/heap/hio.c