]> granicus.if.org Git - postgresql/commit
Clean up the mess around EXPLAIN and materialized views.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 12 Apr 2013 23:25:20 +0000 (19:25 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 12 Apr 2013 23:25:31 +0000 (19:25 -0400)
commit0b337904213337db5026ef0a756a447588023935
treeb8021cade19c6865d839b712c51688d1f56a3868
parent5003f94f661d3eff0c44774576fe2f1ae202da86
Clean up the mess around EXPLAIN and materialized views.

Revert the matview-related changes in explain.c's API, as per recent
complaint from Robert Haas.  The reason for these appears to have been
principally some ill-considered choices around having intorel_startup do
what ought to be parse-time checking, plus a poor arrangement for passing
it the view parsetree it needs to store into pg_rewrite when creating a
materialized view.  Do the latter by having parse analysis stick a copy
into the IntoClause, instead of doing it at runtime.  (On the whole,
I seriously question the choice to represent CREATE MATERIALIZED VIEW as a
variant of SELECT INTO/CREATE TABLE AS, because that means injecting even
more complexity into what was already a horrid legacy kluge.  However,
I didn't go so far as to rethink that choice ... yet.)

I also moved several error checks into matview parse analysis, and
made the check for external Params in a matview more accurate.

In passing, clean things up a bit more around interpretOidsOption(),
and fix things so that we can use that to force no-oids for views,
sequences, etc, thereby eliminating the need to cons up "oids = false"
options when creating them.

catversion bump due to change in IntoClause.  (I wonder though if we
really need readfuncs/outfuncs support for IntoClause anymore.)
26 files changed:
src/backend/commands/createas.c
src/backend/commands/explain.c
src/backend/commands/prepare.c
src/backend/commands/sequence.c
src/backend/commands/tablecmds.c
src/backend/commands/typecmds.c
src/backend/commands/view.c
src/backend/nodes/copyfuncs.c
src/backend/nodes/equalfuncs.c
src/backend/nodes/nodeFuncs.c
src/backend/nodes/outfuncs.c
src/backend/nodes/readfuncs.c
src/backend/parser/analyze.c
src/backend/parser/gram.y
src/backend/parser/parse_clause.c
src/backend/parser/parse_param.c
src/backend/parser/parse_relation.c
src/backend/parser/parse_utilcmd.c
src/include/catalog/catversion.h
src/include/commands/createas.h
src/include/commands/explain.h
src/include/commands/tablecmds.h
src/include/nodes/primnodes.h
src/include/parser/parse_clause.h
src/include/parser/parse_param.h
src/include/parser/parse_relation.h