]> granicus.if.org Git - postgresql/commit
Fix unportable usages of tolower(). On signed-char machines, it is necessary
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 1 Mar 2008 03:26:44 +0000 (03:26 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 1 Mar 2008 03:26:44 +0000 (03:26 +0000)
commit0b173a6e8df85aa2a924003188520adda3e2d16b
treea493dc720041d3253d218c53ae69799e78b0ae62
parent25819aaee3c319088fff39e5efab68b3280d7eaf
Fix unportable usages of tolower().  On signed-char machines, it is necessary
to explicitly cast the output back to char before comparing it to a char
value, else we get the wrong result for high-bit-set characters.  Found by
Rolf Jentsch.  Also, fix several places where <ctype.h> functions were being
called without casting the argument to unsigned char; this is likewise
unportable, but we keep making that mistake :-(.  These found by buildfarm
member salamander, which I will desperately miss if it ever goes belly-up.
src/backend/utils/adt/like_match.c
src/interfaces/ecpg/ecpglib/execute.c
src/interfaces/ecpg/preproc/preproc.y