]> granicus.if.org Git - apache/commit
Remove unnecessary apr_table_do() function casts
authorJacob Champion <jchampion@apache.org>
Thu, 10 Nov 2016 20:53:21 +0000 (20:53 +0000)
committerJacob Champion <jchampion@apache.org>
Thu, 10 Nov 2016 20:53:21 +0000 (20:53 +0000)
commit091f96ee10e3963faacd258c3f64417c7ad21e1c
treeffd8ec24d41ec9a54cf20c7580aaa0ce3ce673fd
parentbcfb765174e9b8ccee202f937178e61e89100dfb
Remove unnecessary apr_table_do() function casts

Function casts can cause hard-to-debug corruption issues if a
declaration is accidentally changed to be incompatible. Luckily, most of
the function casts for apr_table_do() calls are unnecessary. Remove
them, and adjust the signatures for helpers that weren't taking void* as
the first argument.

The remaining helper that requires a cast is http_filter.c's
form_header_field(), which is probably where many of these casts were
copy-pasted from. I have left it as-is: it has other direct callers
besides apr_table_do(), and it's already documented with warnings not to
change the function signature.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1769192 13f79535-47bb-0310-9956-ffa450edef68
modules/http/http_filters.c
modules/http2/h2_from_h1.c
modules/metadata/mod_headers.c
modules/session/mod_session.c
server/util_cookies.c