]> granicus.if.org Git - clang/commit
Sema: Preserve attributes on parameters in instantiated function templates.
authorJordan Rose <jordan_rose@apple.com>
Fri, 8 Mar 2013 22:25:36 +0000 (22:25 +0000)
committerJordan Rose <jordan_rose@apple.com>
Fri, 8 Mar 2013 22:25:36 +0000 (22:25 +0000)
commit0918989f0eed08870e50418df97d1486d977d773
tree1ee344ae7a85e8ed7078211121495d797b313bef
parentc61361b102fcb9be7b64cc493fb797ea551eb8e7
Sema: Preserve attributes on parameters in instantiated function templates.

This was causing correctness issues for ARC and the static analyzer when a
function template has "consumed" Objective-C object parameters (i.e.
parameters that will be released by the function before returning).

The fix is threefold:
(1) Actually copy over the attributes from old ParmVarDecls to new ones.
(2) Have Sema::BuildFunctionType only work for building FunctionProtoTypes,
    which it was doing anyway. This allows us to pass an ExtProtoInfo
    instead of a plain ExtInfo and several flags.
(3) Drop param attributes as part of StripImplicitInstantiation, which is
    used when an implicit instantiation is followed by an explicit one.

<rdar://problem/12685622>

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@176728 91177308-0d34-0410-b5e6-96231b3b80d8
include/clang/Sema/Sema.h
lib/Sema/SemaTemplate.cpp
lib/Sema/SemaTemplateDeduction.cpp
lib/Sema/SemaTemplateInstantiate.cpp
lib/Sema/SemaType.cpp
lib/Sema/TreeTransform.h
test/CodeGenObjCXX/arc-attrs.mm [new file with mode: 0644]
test/SemaObjCXX/arc-nsconsumed-errors.mm