]> granicus.if.org Git - postgresql/commit
Fix an old bug in multixact and two-phase commit. Prepared transactions can
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 23 Nov 2009 09:59:00 +0000 (09:59 +0000)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 23 Nov 2009 09:59:00 +0000 (09:59 +0000)
commit0852c4d54cc393cbe6432e27e45ba99be3a5f7d8
tree2e8ddbd8240b25fd3955584207d97785d28ada40
parent31f38e3f0e560a075606107cdb5fe8c0db5c7c60
Fix an old bug in multixact and two-phase commit. Prepared transactions can
be part of multixacts, so allocate a slot for each prepared transaction in
the "oldest member" array in multixact.c. On PREPARE TRANSACTION, transfer
the oldest member value from the current backends slot to the prepared xact
slot. Also save and recover the value from the 2pc state file.

The symptom of the bug was that after a transaction prepared, a shared lock
still held by the prepared transaction was sometimes ignored by other
transactions.

Fix back to 8.1, where both 2PC and multixact were introduced.
src/backend/access/transam/multixact.c
src/backend/access/transam/twophase.c
src/backend/access/transam/twophase_rmgr.c
src/backend/access/transam/xact.c
src/include/access/multixact.h
src/include/access/twophase.h
src/include/access/twophase_rmgr.h