]> granicus.if.org Git - postgresql/commit
Fix another oversight in CustomScan patch.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 20 Nov 2014 20:56:39 +0000 (15:56 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 20 Nov 2014 20:56:39 +0000 (15:56 -0500)
commit081a6048cff07a83591ebcb08b676a771ae58d2b
tree775ba9050c521529a05d1cd9a899d072df5c425a
parent03e574af5f5d4682ce3ae6dc401ba126c70ce2ea
Fix another oversight in CustomScan patch.

execCurrent.c's search_plan_tree() must recognize a CustomScan on the
target relation.  This would only be helpful for custom providers that
support CurrentOfExpr quals, which is probably a bit far-fetched, but
it's not impossible I think.  But even without assuming that, we need
to recognize a scanned-relation match so that we will properly throw
error if the desired relation is being scanned with both a CustomScan
and a regular scan (ie, self-join).

Also recognize ForeignScanState for similar reasons.  Supporting WHERE
CURRENT OF on a foreign table is probably even more far-fetched than
it is for custom scans, but I think in principle you could do it with
postgres_fdw (or another FDW that supports the ctid column).  This
would be a back-patchable bug fix if existing FDWs handled CurrentOfExpr,
but I doubt any do so I won't bother back-patching.
src/backend/executor/execCurrent.c