]> granicus.if.org Git - clang/commit
[Diagnostics] Implement -Wsizeof-pointer-div
authorDavid Bolvansky <david.bolvansky@gmail.com>
Thu, 1 Nov 2018 16:26:10 +0000 (16:26 +0000)
committerDavid Bolvansky <david.bolvansky@gmail.com>
Thu, 1 Nov 2018 16:26:10 +0000 (16:26 +0000)
commit08118ba8c73dd1bd2f9626121d481be5b8703ba3
tree850ec76e8badd684da91724a26e0a5ec2889a69c
parent2c052ed30cc5dd4fa91e43f8c3d8a06e812c554c
[Diagnostics] Implement -Wsizeof-pointer-div

Summary:
void test(int *arr) {
    int arr_len = sizeof(arr) / sizeof(*arr);  // warn, incorrect way to compute number of array elements
}

Enabled under -Wall (same behaviour as GCC)

Reviewers: rsmith, MTC, aaron.ballman

Reviewed By: aaron.ballman

Subscribers: MTC, thakis, jfb, cfe-commits

Differential Revision: https://reviews.llvm.org/D52949

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@345847 91177308-0d34-0410-b5e6-96231b3b80d8
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/Sema/div-sizeof-ptr.cpp [new file with mode: 0644]