]> granicus.if.org Git - postgresql/commit
Do all accesses to shared buffer headers through volatile-qualified
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 12 Oct 2005 16:45:14 +0000 (16:45 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 12 Oct 2005 16:45:14 +0000 (16:45 +0000)
commit07eeb9d109c057854b20707562ce517efa591761
treec327a5d0acf471e00737609bf8ddd3fbbd18ee66
parent6b97e437ca20cbfcff059c668516c59914f5ba4d
Do all accesses to shared buffer headers through volatile-qualified
pointers, to ensure that compilers won't rearrange accesses to occur
while we're not holding the buffer header spinlock.  It's probably
not necessary to mark volatile in every single place in bufmgr.c,
but better safe than sorry.  Per trouble report from Kevin Grittner.
contrib/pg_buffercache/pg_buffercache_pages.c
src/backend/storage/buffer/bufmgr.c
src/backend/storage/buffer/freelist.c
src/include/storage/buf_internals.h