]> granicus.if.org Git - llvm/commit
[GVN] Remove a todo introduced w/rL370791
authorPhilip Reames <listmail@philipreames.com>
Tue, 3 Sep 2019 21:56:17 +0000 (21:56 +0000)
committerPhilip Reames <listmail@philipreames.com>
Tue, 3 Sep 2019 21:56:17 +0000 (21:56 +0000)
commit074bcc7643487853df21590c47c971215a31cdeb
tree30f383b4948fb0bd0e236b43d9d942a16173f080
parent3b8e736c5897703ad61d56678c2f0dec2fe2d04e
[GVN] Remove a todo introduced w/rL370791

When I dug into this, it turns out to be *much* more involved than I'd realized and doesn't actually simplify anything.

The general purpose of the leader table is that we want to find the most-dominating definition quickly.  The problem for equivalance folding is slightly different; we want to find the most dominating *value* whose definition block dominates our use quickly.

To make this change, we'd end up having to restructure the leader table (either the sorting thereof, or maybe even introducing multiple leader tables per value) and that complexity is just not worth it.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@370824 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Transforms/Scalar/GVN.cpp