]> granicus.if.org Git - clang/commit
[clang-format] [PR41170] Break after return type ignored with certain comments positions
authorPaul Hoad <mydeveloperday@gmail.com>
Mon, 15 Apr 2019 07:47:15 +0000 (07:47 +0000)
committerPaul Hoad <mydeveloperday@gmail.com>
Mon, 15 Apr 2019 07:47:15 +0000 (07:47 +0000)
commit070ab5cd47cde6bb757e1897a93e8c08edbdeaae
tree54b3a287b852cf2b328336a78f553e1c41536e12
parentcab7f1f7bc141ac88d15030088b311bd450b2c94
[clang-format] [PR41170] Break after return type ignored with certain comments positions

Summary:
Addresses https://bugs.llvm.org/show_bug.cgi?id=41170

The AlwaysBreakAfterReturn type setting can go wrong if the line ends with a comment
```
void foo() /* comment */
```
or

```
void foo() // comment
```

It will incorrectly see such functions as Declarations and not Definitions

The following code addresses this by looking for function which end with `; <comment>` rather than just `;` or `<comment>`

Reviewers: klimek, djasper, reuk, russellmcc, owenpan, sammccall
Reviewed By: owenpan
Subscribers: lebedev.ri, cfe-commits, sammccall
Tags: #clang
Differential Revision: https://reviews.llvm.org/D60363

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@358375 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Format/TokenAnnotator.h
unittests/Format/FormatTest.cpp