]> granicus.if.org Git - postgresql/commit
Put back pqsignal() as an exported libpq symbol.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 10 Oct 2019 18:24:56 +0000 (14:24 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 10 Oct 2019 18:24:56 +0000 (14:24 -0400)
commit06a367c382d0a3595238eff2e777222dbc91911b
tree2c5896ecae3f20f756d634750627be991fb5c92e
parent3b5d3721c25ed1270832265c5475649c3baa0e26
Put back pqsignal() as an exported libpq symbol.

This reverts commit f7ab80285.  Per discussion, we can't remove an
exported symbol without a SONAME bump, which we don't want to do.
In particular that breaks usage of current libpq.so with pre-9.3
versions of psql etc, which need libpq to export pqsignal().

As noted in that commit message, exporting the symbol from libpgport.a
won't work reliably; but actually we don't want to export src/port's
implementation anyway.  Any pre-9.3 client is going to be expecting the
definition that pqsignal() had before 9.3, which was that it didn't
set SA_RESTART for SIGALRM.  Hence, put back pqsignal() in a separate
source file in src/interfaces/libpq, and give it the old semantics.

Back-patch to v12.

Discussion: https://postgr.es/m/E1g5vmT-0003K1-6S@gemulon.postgresql.org
src/interfaces/libpq/Makefile
src/interfaces/libpq/exports.txt
src/interfaces/libpq/legacy-pqsignal.c [new file with mode: 0644]