]> granicus.if.org Git - postgresql/commit
Clean up ill-advised attempt to invent a private set of Node tags.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 6 Aug 2011 18:53:49 +0000 (14:53 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 6 Aug 2011 18:53:49 +0000 (14:53 -0400)
commit05e83968929f4ec1eba058fcae755fd2df98864e
tree7ffac5eb9aa9587d20a60d8fac592763f7ae7bac
parentffcf5a6c41ce91c55991b04eea1fcb94e4d0faa0
Clean up ill-advised attempt to invent a private set of Node tags.

Somebody thought it'd be cute to invent a set of Node tag numbers that were
defined independently of, and indeed conflicting with, the main tag-number
list.  While this accidentally failed to fail so far, it would certainly
lead to trouble as soon as anyone wanted to, say, apply copyObject to these
node types.  Clang was already complaining about the use of makeNode on
these tags, and I think quite rightly so.  Fix by pushing these node
definitions into the mainstream, including putting replnodes.h where it
belongs.
src/backend/replication/repl_gram.y
src/backend/replication/walsender.c
src/include/nodes/nodes.h
src/include/nodes/replnodes.h [moved from src/include/replication/replnodes.h with 80% similarity]
src/include/replication/basebackup.h